Skip to content

Update process to filter out starting comments in a source yaml file#4707

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/kubectl_source_url_support
Sep 29, 2025
Merged

Update process to filter out starting comments in a source yaml file#4707
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/kubectl_source_url_support

Conversation

@SwarnaBharathiMantena
Copy link
Copy Markdown
Contributor

The modules/management/kubectl-apply/kubectl module failed to install the MPI Operator when the source https://raw.githubusercontent.com/kubeflow/mpi-operator/v0.6.0/deploy/v2beta1/mpi-operator.yaml was passed under apply_manifests setting of the module.
This was because of the comments present at the beginning of the mpi-operator.yaml file.

This PR fixes the bug by updating the logic to check malformed documents (like comment blocks) which cause yamldecode() to fail.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the bug Something isn't working label Sep 29, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena added release-bugfix Added to release notes under the "Bug fixes" heading. and removed bug Something isn't working labels Sep 29, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 254da3b into GoogleCloudPlatform:develop Sep 29, 2025
15 of 68 checks passed
@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/kubectl_source_url_support branch October 13, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants