Skip to content

Update H4D blueprint: disable automatic updates, provide image info, and delete duplicate filestore#4644

Merged
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
Neelabh94:cleanup/h4d_blueprint_updates
Sep 24, 2025
Merged

Update H4D blueprint: disable automatic updates, provide image info, and delete duplicate filestore#4644
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
Neelabh94:cleanup/h4d_blueprint_updates

Conversation

@Neelabh94
Copy link
Copy Markdown
Contributor

@Neelabh94 Neelabh94 commented Sep 12, 2025

The PR makes the following changes to the H4D blueprint:

1> Disable automatic updates to prevent unattended updates leading to unstable clusters.

2> Explicitly mention the image used for nodeset, controller and login nodes within the blueprint instead of relying solely on the default in CTK.

3> Removes duplicate file store "appfs". There's no benefit of having two separate file store instances in the base blueprint. There are probably use cases of using separate file stores for specific apps but is not a general practice and hence needs to be removed.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@Neelabh94 Neelabh94 force-pushed the cleanup/h4d_blueprint_updates branch from c319207 to 3aeecfa Compare September 12, 2025 05:22
@Neelabh94 Neelabh94 added the release-improvements Added to release notes under the "Improvements" heading. label Sep 12, 2025
@Neelabh94 Neelabh94 self-assigned this Sep 12, 2025
@Neelabh94 Neelabh94 closed this Sep 12, 2025
@Neelabh94 Neelabh94 reopened this Sep 12, 2025
@Neelabh94 Neelabh94 marked this pull request as ready for review September 12, 2025 07:11
@Neelabh94 Neelabh94 requested review from a team and samskillman as code owners September 12, 2025 07:11
Comment thread examples/hpc-slurm-h4d.yaml
Comment thread examples/hpc-slurm-h4d.yaml Outdated
@Neelabh94 Neelabh94 force-pushed the cleanup/h4d_blueprint_updates branch from 3aeecfa to 567ba4e Compare September 12, 2025 08:26
Copy link
Copy Markdown
Collaborator

@samskillman samskillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline suggestions

Comment thread examples/hpc-slurm-h4d.yaml Outdated
Comment thread examples/hpc-slurm-h4d.yaml Outdated
Comment thread examples/hpc-slurm-h4d.yaml Outdated
Comment thread examples/hpc-slurm-h4d.yaml Outdated
Comment thread examples/hpc-slurm-h4d.yaml Outdated
@Neelabh94 Neelabh94 force-pushed the cleanup/h4d_blueprint_updates branch from 8b5a78b to de52e41 Compare September 24, 2025 04:07
@Neelabh94 Neelabh94 enabled auto-merge September 24, 2025 04:08
@Neelabh94 Neelabh94 disabled auto-merge September 24, 2025 04:23
@Neelabh94 Neelabh94 dismissed stale reviews from samskillman and bytetwin September 24, 2025 04:25

All requested changes made.

@Neelabh94 Neelabh94 merged commit 8183d57 into GoogleCloudPlatform:develop Sep 24, 2025
13 of 64 checks passed
@Neelabh94 Neelabh94 deleted the cleanup/h4d_blueprint_updates branch September 24, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants