Hello! I am a with the Google Cloud NetApp Volume (GCNV) team and are working on integrating GCNV as a new NFS file-system into ClusterToolkit. My PoC is already running pretty fine, just needs a few finishing touches and a lot of documentation.

This is my first micro PR to get acquainted with the contribution process and introduce myself. The PR make a static into an variable which defaults to the old static value. User can now specify an alternative value. I am using it successfully for over a week now.

Example code:

...
deployment_groups:
- group: primary
  modules:
  # Source is an embedded module, denoted by "modules/*" without ./, ../, /
  # as a prefix. To refer to a local module, prefix with ./, ../ or /
  - id: network
    source: modules/network/vpc
    settings:
      network_name: $(vars.network)
      region: $(vars.region)

  - id: private_service_access
    source: community/modules/network/private-service-access
    use: [network]
    settings:
      prefix_length: 24
      service_name: "netapp.servicenetworking.goog"
...

Only issue is the destroy behaviour:

Error: Unable to remove Service Networking Connection, err: Error waiting for Delete Service Networking Connection: Error code 9, message: Failed to delete connection; Producer services (e.g. CloudSQL, Cloud Memstore, etc.) are still using this connection.

But that's not related to the my change, but to the fact that GCNV releases the peering lazily. I have seen the same PSA behaviour with CloudSQL. service_networking_connection offers the deletion_policy parameter to workaround such issues. I can add that parameter to this module too as variable, if requested.

What do you think?

Thank you for the feedback. I did a few additional changes and will update the PR after doing some testing.

Hello @samskillman, I added support for deletion_policy, added documentation and made sure the pre-commit hocks work fine.
I tested both the traditional workflow with servicenetworking and the new one for GCNV.

Please have a look. I plan to PR changes to add support for modules/file-system/netapp-storage-pool and modules/file-system/netapp-volume by the end of the week. Code is running fine. I need to add proper documentation and provide a baseline blueprint which provides shared filesystem(s) which can be used by other blueprints.

Adding @bytetwin as a second reviewer, which is required in this case.

@bytetwin Hello, I have more PRs queued up which build on top of this one. I am hesitant to PR them while this is still "in the air". Will you find time to look at this soon or should I PR my other changes anyway? They will include this one too, but I am for small PRs to make them small and contained. Please advise.

/gcbrun

Thank you!