Skip to content

Fix guest accelerator (broken for GKE)#3656

Merged
annuay-google merged 1 commit into
GoogleCloudPlatform:developfrom
annuay-google:annuay/fix-guest-accelerator
Feb 10, 2025
Merged

Fix guest accelerator (broken for GKE)#3656
annuay-google merged 1 commit into
GoogleCloudPlatform:developfrom
annuay-google:annuay/fix-guest-accelerator

Conversation

@annuay-google
Copy link
Copy Markdown
Contributor

Fixes breaking change introduced in #3448
Guest accelerator config for GKE node pool differs from that of Compute Instance

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@annuay-google annuay-google changed the base branch from main to develop February 10, 2025 08:50
@annuay-google annuay-google added the release-bugfix Added to release notes under the "Bug fixes" heading. label Feb 10, 2025
@SwarnaBharathiMantena
Copy link
Copy Markdown
Contributor

LGTM

@annuay-google annuay-google merged commit 0107923 into GoogleCloudPlatform:develop Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants