Adding var.provisioning_model to vm-instance module#3588
Merged
RachaelSTamakloe merged 1 commit intoJan 24, 2025
Merged
Conversation
RachaelSTamakloe
added
the
release-module-improvements
tpdownes
approved these changes
Jan 24, 2025
Contributor
tpdownes
left a comment
tpdownes
left a comment
There was a problem hiding this comment.
Approved with minor text change.
mr0re1
reviewed
Jan 24, 2025
RachaelSTamakloe
force-pushed
the
provisioning_model
branch
from
1f5bdaa to
932af49
Compare
mr0re1
approved these changes
Jan 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I deprecate the
var.spotvariable and add in thevar.provisioning_modelvariable in the vm-instance module. This enables the vm-instace module to support other provisioning models outside of "SPOT".Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.