Skip to content

Add H4d Slurm cluster example#3586

Merged
abbas1902 merged 1 commit into
GoogleCloudPlatform:developfrom
abbas1902:slurmy
Jan 24, 2025
Merged

Add H4d Slurm cluster example#3586
abbas1902 merged 1 commit into
GoogleCloudPlatform:developfrom
abbas1902:slurmy

Conversation

@abbas1902
Copy link
Copy Markdown
Collaborator

Add an example of an H4d cluster that deploys with Slurm.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-chore To not include into release notes label Jan 23, 2025
@abbas1902 abbas1902 requested a review from tpdownes January 23, 2025 22:56
@abbas1902 abbas1902 force-pushed the slurmy branch 3 times, most recently from f697be7 to aa39913 Compare January 24, 2025 19:35
Copy link
Copy Markdown
Contributor

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM but I'd like you to address the public IP question.

Comment thread community/examples/hpc-slurm-h4d.yaml Outdated
@tpdownes tpdownes assigned abbas1902 and unassigned tpdownes Jan 24, 2025
@tpdownes tpdownes assigned abbas1902 and unassigned tpdownes Jan 24, 2025
@abbas1902 abbas1902 merged commit b2dc4d2 into GoogleCloudPlatform:develop Jan 24, 2025
@abbas1902 abbas1902 deleted the slurmy branch January 24, 2025 22:34
@abbas1902 abbas1902 added release-key-new-features Added to release notes under the "Key New Features" heading. and removed release-chore To not include into release notes labels Feb 5, 2025
@abbas1902 abbas1902 mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants