Skip to content

enable queued provisioning on gke nodepool#3582

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke_nodepool_enable_queued_provisioning
Feb 3, 2025
Merged

enable queued provisioning on gke nodepool#3582
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke_nodepool_enable_queued_provisioning

Conversation

@SwarnaBharathiMantena
Copy link
Copy Markdown
Contributor

@SwarnaBharathiMantena SwarnaBharathiMantena commented Jan 23, 2025

Enable queued provisioning on gke nodepool.

  • Add the enable_queued_provisioning boolean variable.
  • Update both google and google-beta provider version to >= 6.16
  • Add preconditions: 1. to ensure placement_policy is not set to COMPACT when enable_queued_provisioning is true. 2. to ensure reservation_affinity is NO_RESERVATION when enable_queued_provisioning is true.

This enables us to support DWS Flex for A3 Mega machine type.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-key-new-features Added to release notes under the "Key New Features" heading. label Jan 23, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_nodepool_enable_queued_provisioning branch from 2c6c45f to e7b829d Compare January 24, 2025 15:47
@annuay-google
Copy link
Copy Markdown
Contributor

Please run PR-test-ml-gke, rest LGTM

@annuay-google annuay-google added release-module-improvements Added to release notes under the "Module Improvements" heading. and removed release-key-new-features Added to release notes under the "Key New Features" heading. labels Feb 3, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 21b6664 into GoogleCloudPlatform:develop Feb 3, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/gke_nodepool_enable_queued_provisioning branch March 28, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants