Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Add Chrome extension sample#49

Merged
tswast merged 2 commits intoGoogleCloudPlatform:masterfrom
imjasonh:master
Mar 21, 2016
Merged

Add Chrome extension sample#49
tswast merged 2 commits intoGoogleCloudPlatform:masterfrom
imjasonh:master

Conversation

@imjasonh
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@imjasonh
Copy link
Copy Markdown
Contributor Author

I'm a Google employee, my @google.com email address wasn't my GitHub profile's primary email address, but it is now.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@@ -0,0 +1,189 @@
// http makes an HTTP request and calls callback with parsed JSON.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Apache 2 Google license header.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@imjasonh
Copy link
Copy Markdown
Contributor Author

Silly CLA bot, I had reset my @gmail.com account to primary, my bad.

@tswast
Copy link
Copy Markdown
Contributor

tswast commented Mar 21, 2016

LGTM.

Thanks!

tswast added a commit that referenced this pull request Mar 21, 2016
Add Chrome extension sample
@tswast tswast merged commit e46c1d1 into GoogleCloudPlatform:master Mar 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants