Conversation
suztomo
approved these changes
Nov 30, 2020
Contributor
suztomo
left a comment
suztomo
left a comment
There was a problem hiding this comment.
Thank you for taking care of this.
| @Test | ||
| public void testCommandLine() { | ||
| String[] arguments = {"something"}; | ||
| LinkageMonitor.parseCommandLine(arguments); |
Contributor
There was a problem hiding this comment.
How about checking the return value to ensure the code below (at line 96 of LinkageMonitor.java) works fine?
CommandLine commandLine = parseCommandLine(arguments);
String bomCoordinates = commandLine.getArgList().get(0);
Note for myself: Linkage Monitor is invoked with the versionless coordinates. (doc)
java -jar linkage-monitor-X.Y.Z-all-deps.jar com.google.cloud:libraries-bom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@suztomo fixes #1838