Add koa@next support#97
Conversation
cristiancavalli
force-pushed
the
add-koa-next-interface
branch
2 times, most recently
from
1a6ed1c to
77cb5ba
Compare
- Add interface for koa@next through .koaNext
method property.
- Add documentation to readme and new code.
- Add tests and server scaffolds.
- Add `npm-install-version` as development
dependency to use koa@next scaffolds.
|
@GoogleCloudPlatform/node-team ptal |
|
|
||
| // Will attach to 'error' event which includes | ||
| // request/response lifecycle errors | ||
| errors.koaNext(app); |
There was a problem hiding this comment.
Quick question: I would assume that koa@next moves pretty fast. Do we think this integration would be stable, i.e. we won't be broken as koa@next changes?
There was a problem hiding this comment.
I think it would be stable for our purposes and the API surface which we wish to exercise. It may break though given that it's OSS and in-development. These mocks are meant to break, though, given that the API surface changes so that we can know about it
| @@ -0,0 +1,46 @@ | |||
| /** | |||
There was a problem hiding this comment.
Like with the express5, how is this file hooked into the tests?
|
@ofrobots None of the scaffold servers are hooked into automated test runs like we discussed before |
|
Any further work in this area will be done in the google-cloud-node/error-reporting repository and is being tracked by issue 2295 in that repository. |
4 participants
method property.
npm-install-versionas developmentdependency to use koa@next scaffolds.