Add Python Hello World sample. [DO NOT MERGE]#173
Conversation
googlebot
added
the
cla: yes
This runs the hello.py script in a fresh Python "virtual environment" and checks that the output matches what we expect.
|
@lesv PTAL. |
| @@ -0,0 +1,67 @@ | |||
| # Cloud Bigtable Hello World | |||
|
|
|||
| This is a simple application that demonstrates using the [Google Cloud Client | |||
|
We may decide (tomorrow's chat) to put this in python-docs-samples. I'm basically happy. Surprised how simple this is. @jonparrott PTAL |
| Delete table Hello-Bigtable-1234 | ||
| ``` | ||
|
|
||
| ## Understanding the code |
There was a problem hiding this comment.
Doesn't this stuff usually go in the docs? Do you think it's worthwhile to duplicate this here or would it be better to link to the documentation page that describes this sample?
There was a problem hiding this comment.
I'd prefer to see this stuff in the README as well as the docs. Code should always have everything you need, IMHO.
There was a problem hiding this comment.
I think "everything you need" is satisfied by a link to the tutorial for this sample, yeah? Otherwise we risk the "official" tutorial in our docs and this version of the tutorial drifting.
If this does not yet have a companion documentation tutorial, then this can remain.
There was a problem hiding this comment.
Yea - I prefer duplication as sometimes different ways of saying the same thing makes it easier to get. (And when I'm working, I prefer to look at my IDE and not a web page.
There was a problem hiding this comment.
Fair enough, I'm okay with it as long as it stays relatively minimal.
|
LGTM - You need to take a look, I'm going to update master on your branch, however. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
4 participants
Uses the HappyBase layer, as recommended by Bigtable eng.