Add query for slider/carousel usage #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
force-pushed
the
add/slider-usage-query
branch
from
ac80549 to
d4b9237
Compare
felixarntz
approved these changes
Apr 22, 2025
Collaborator
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@swissspidy Looks good, just an optional recommendation.
Comment on lines
+33
to
+56
| CREATE TEMPORARY FUNCTION | ||
| HAS_SLIDER(technologies ARRAY<STRUCT<technology STRING, | ||
| categories ARRAY<STRING>, | ||
| info ARRAY<STRING>>>) | ||
| RETURNS BOOL AS ( | ||
| EXISTS( | ||
| SELECT | ||
| * | ||
| FROM | ||
| UNNEST(technologies) AS technology | ||
| WHERE | ||
| technology.technology IN ( | ||
| 'FlexSlider', | ||
| 'Flickity', | ||
| 'Master Slider', | ||
| 'MetaSlider', | ||
| 'OWL Carousel', | ||
| 'Slick', | ||
| 'Slider Revolution', | ||
| 'Smart Slider 3', | ||
| 'Swiper' | ||
| ) | ||
| ) | ||
| ); |
Collaborator
There was a problem hiding this comment.
This is pretty much the same as HAS_TECHNOLOGY, except that it looks for one of multiple technologies.
You could get rid of the two functions in favor of a tiny change to make HAS_TECHNOLOGY expect an array of strings instead of a single string. Then you can pass all the technologies to the function.
You could keep HAS_SLIDER() if you think it has value but have it call HAS_TECHNOLOGIES.
Not a big deal, but avoids duplicate implementation of almost the same piece of query.
Collaborator
Author
There was a problem hiding this comment.
Yeah I thought about that but figured it doesn't really matter for a one off query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 2025-03-01 dataset, ~54% of all WordPress sites use one of these slider/carousel libraries.
The list of plugins/libraries is based on some manual research and is not meant to be exhaustive.
This is relevant for things like https://core.trac.wordpress.org/ticket/63251
I am sharing these numbers in an upcoming blog post and need to store the query somewhere, so here I am :)