Make README.md canonical, generating readme.txt at build time #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
remove/readme.txt
branch
from
ecd559b to
991508e
Compare
westonruter
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #400 +/- ##
=============================================
- Coverage 24.19% 23.26% -0.94%
Complexity 364 364
=============================================
Files 55 56 +1
Lines 1872 1947 +75
=============================================
Hits 453 453
- Misses 1419 1494 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ove/readme.txt * 'develop' of github.com:GoogleChromeLabs/pwa-wp: (26 commits) Bump @wordpress/plugins from 2.24.6 to 2.24.7 Bump @wordpress/plugins from 2.24.5 to 2.24.6 Bump eslint-plugin-jsdoc from 32.1.0 to 32.2.0 Bump eslint from 7.20.0 to 7.21.0 Bump eslint-plugin-jsdoc from 32.0.1 to 32.1.0 Bump eslint-plugin-jsdoc from 32.0.0 to 32.0.1 Bump eslint from 7.19.0 to 7.20.0 Bump @wordpress/eslint-plugin from 8.0.1 to 8.0.2 Bump @wordpress/plugins from 2.24.2 to 2.24.5 Bump phpcompatibility/phpcompatibility-wp from 2.1.0 to 2.1.1 Bump eslint-plugin-jsdoc from 31.6.0 to 32.0.0 Bump @wordpress/scripts from 13.0.1 to 13.0.3 Bump lint-staged from 10.5.3 to 10.5.4 Use wp_robots() to prevent indexing the error template on WP≥5.7 Bump eslint from 7.18.0 to 7.19.0 Bump eslint-plugin-jsdoc from 31.4.0 to 31.6.0 Bump @wordpress/eslint-plugin from 8.0.0 to 8.0.1 Bump @wordpress/scripts from 13.0.0 to 13.0.1 Bump eslint-plugin-jsdoc from 31.3.3 to 31.4.0 Bump eslint-plugin-jsdoc from 31.3.2 to 31.3.3 ...
|
QA Passed ✅ readme.txt is getting generated at build time as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining
readme.txtand synchronizing it toreadme.md, we can just keep the markdown version alone and then generate thereadme.txtat build time. Based on learnings from ampproject/amp-wp#5807 and ampproject/amp-wp#5815.Also eliminates
xwp/wp-dev-libdependency, which is obsolete now that we're no longer usinggenerate-markdown-readmenor thecheck-diff.sh(sincelint-stagedwas added in #354).