Skip to content

Fallback to default getSelector if custom function is null or undefined #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tunetheweb merged 2 commits into from
Jul 15, 2025
Merged

Fallback to default getSelector if custom function is null or undefined #634

tunetheweb merged 2 commits into from
Jul 15, 2025
+98 −25

Conversation

@tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jul 14, 2025

Fixes #633

@tunetheweb tunetheweb mentioned this pull request Jul 14, 2025
Closed
@tunetheweb tunetheweb requested a review from philipwalton July 14, 2025 12:38
philipwalton
philipwalton reviewed Jul 14, 2025
View reviewed changes
@tunetheweb tunetheweb merged commit f16c4b4 into main Jul 15, 2025
9 checks passed
@tunetheweb tunetheweb deleted the generate-target-fallback branch July 15, 2025 07:14
@logaretm logaretm mentioned this pull request Nov 12, 2025
Merged
logaretm added a commit to getsentry/sentry-javascript that referenced this pull request Nov 18, 2025
@logaretm
feat(browser-utils): bump web-vitals to 5.1.0 (#18091)
610ae69 
Bumps the vendored-in web vitals library to include the changes between
`5.0.2` <-> `5.1.0` from upstream

#### Changes from upstream

- Remove `visibilitychange` event listeners when no longer required
[#627](GoogleChrome/web-vitals#627)
- Register visibility-change early
[#637](GoogleChrome/web-vitals#637)
- Only finalize LCP on user events (isTrusted=true)
[#635](GoogleChrome/web-vitals#635)
- Fallback to default getSelector if custom function is null or
undefined [#634](GoogleChrome/web-vitals#634)

#### Our own Changes

- Added `addPageListener` and `removePageListener` utilities because the
upstream package changed the listeners to be added on `window` instead
of `document`, so I added those utilities to avoid having to check for
window every time we try to add a listener.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipwalton philipwalton philipwalton left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

generateTarget is not ergnomic to use

2 participants

@tunetheweb @philipwalton