core(trace-elements): handle shadow roots #16718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that for dbw tester, the dom-size-insight max children field was not getting a node element. There was a node id, but it pointed at the document fragment inside a shadow tree. The TraceElements saw it was not an element node, so it went to the parentElement. But since it's a shadow root, there is no parent element, and thus no node reference was created.
Instead, check if the element is a shadow root. If so, use its host.