Skip to content

Conversation

@connorjclark
Copy link
Collaborator

I noticed that for dbw tester, the dom-size-insight max children field was not getting a node element. There was a node id, but it pointed at the document fragment inside a shadow tree. The TraceElements saw it was not an element node, so it went to the parentElement. But since it's a shadow root, there is no parent element, and thus no node reference was created.

Instead, check if the element is a shadow root. If so, use its host.

@connorjclark connorjclark requested a review from a team as a code owner October 2, 2025 21:50
@connorjclark connorjclark requested review from paulirish and removed request for a team October 2, 2025 21:50
@connorjclark connorjclark merged commit 1515116 into main Oct 2, 2025
28 checks passed
@connorjclark connorjclark deleted the fix-shadows-roots branch October 2, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant