misc: revert json modules to fully support Node 20 #16613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Aug 1, 2025
| name: node ${{ matrix.node }} | ||
| env: | ||
| CHROME_PATH: ${{ github.workspace }}/.tmp/chrome-tot/chrome | ||
| LATEST_NODE: '18' |
Collaborator
Author
There was a problem hiding this comment.
this should have been "20" for a while now. nbd, I think just meant we collecting coverage info on 18 instead.
Closed
connorjclark
changed the title
This reverts commit 4a84063.
connorjclark
force-pushed
the
revert-json-modules
branch
from
b5fb5f0 to
3d462f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #16500 (comment)
Node 20.10 was the first v20 that supported json modules. A mix of unclear policy on what we support, and no matching CI matrix, allowed this to go under the radar. We're gonna do a major release in a month but let's fix this anyways.
Reverts these two PRs:
withimport attributes for legacy-javascript, bump to node 18.20 #16415Also added 20.9 as a specific version in CI unit tests.