tests: add test for trace-engine-result #16574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Jul 2, 2025
|
|
||
| bigTrace.traceEvents.push(...measureEvents); | ||
|
|
||
| result = await TraceEngineResult.request( |
Collaborator
There was a problem hiding this comment.
This result is re-used in later test, which means those other tests don't work in isolation. Please do this work in a before hook.
connorjclark
reviewed
Jul 7, 2025
| ); | ||
| assert.ok(result.insights); | ||
| assert.ok(result.parsedTrace); | ||
| result.insights.values().forEach(insightSet => { |
Collaborator
There was a problem hiding this comment.
probably forEach not supported on map iterators in node 18
can just use a for loop instead
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.