Skip to content

core(timing-summary): suppress expected errors #16520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 1 commit into from
Jun 4, 2025
Merged

core(timing-summary): suppress expected errors #16520

connorjclark merged 1 commit into from
Jun 4, 2025

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jun 3, 2025

I didn't realize in #16492 that this would log expected errors on most runs:

LH:lh:computed:TimingSummary:error Error: FCP All Frames not implemented in lantern

@connorjclark connorjclark requested a review from a team as a code owner June 3, 2025 21:49
@connorjclark connorjclark requested review from paulirish and removed request for a team June 3, 2025 21:49
@connorjclark connorjclark changed the title core(timing-summary): supress expected errors core(timing-summary): suppress expected errors Jun 3, 2025
@connorjclark connorjclark merged commit 8a3bc67 into main Jun 4, 2025
28 checks passed
@connorjclark connorjclark deleted the timing-summary-fix branch June 4, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulirish paulirish paulirish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connorjclark @paulirish