tests: use newer trace in metrics test #16492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
changed the title
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
May 20, 2025
Requests that never send a response are a thing that happens: * Long-polling requests that never end * The trace ended before the request did We should not exclude these from the trace processor. This helps with Lantern - see GoogleChrome/lighthouse#16492. Additionally, I think this handler wanted to filter out data urls, but it wasn't doing it directly so some got through. That should be fixed now. Bug: none Change-Id: I911211512055667fa2deb125dd64389ce8968324 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6569818 Auto-Submit: Connor Clark <[email protected]> Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Connor Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking at fixing the remaining differences between the trace and devtools log network records used for Lantern (ctrl+f
INTERNAL_LANTERN_USE_TRACE).