core(insights): implement duplicated-javascript-insight
#16456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
force-pushed
the
dupe-js-insight
branch
from
75cd778 to
a71a73e
Compare
paulirish
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #16323
Implements the
duplicated-javascript-insightaudit.I also noticed something that we need to resolve. All byte eff audits (including dupe js, legacy js) represent their byte values as network transfer sizes (both in the JSON and in the report via displayValue and individual item rows). However, currently in the trace engine insight model + RPP for these insights, the individual item rows are in terms of resource size savings (so are
Est savings). Need to resolve this difference. EDIT: resolved here, will grab in next TraceEngine dep update