Skip to content

core: modify scoreDisplayMode for insight audits to match Perf panel #16432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 1 commit into from
Apr 11, 2025
Merged

core: modify scoreDisplayMode for insight audits to match Perf panel #16432

connorjclark merged 1 commit into from
Apr 11, 2025

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Apr 8, 2025 •
edited
Loading

  1. removes the hardcoded score setting for a couple insights
  2. sets score display mode based on state in a way that better matches what Perf panel would show

@connorjclark connorjclark requested a review from a team as a code owner April 8, 2025 18:45
@connorjclark connorjclark requested review from paulirish and removed request for a team April 8, 2025 18:45
@connorjclark connorjclark merged commit 1e78ca9 into main Apr 11, 2025
26 of 28 checks passed
@connorjclark connorjclark deleted the fix-insight-audit-score-display branch April 11, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulirish paulirish Awaiting requested review from paulirish paulirish is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@connorjclark