Skip to content

misc(treemap): vary colors within bundle, update fonts #16403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 1 commit into from
Mar 28, 2025
Merged

misc(treemap): vary colors within bundle, update fonts #16403

connorjclark merged 1 commit into from
Mar 28, 2025

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Mar 21, 2025 •
edited
Loading

ref #16400

  • Uses a color of varying saturation/lightness based on depth within each bundle. This could be tweaked more, not perfect
  • Applies some font styling to better match mocks
  • Splits up captions into separate elements to style differently
  • Removes root node caption for "All" scripts

image
image
image

@connorjclark connorjclark requested a review from a team as a code owner March 21, 2025 23:12
@connorjclark connorjclark requested review from adamraine and removed request for a team March 21, 2025 23:12
@adamraine
Copy link
Contributor

adamraine commented Mar 21, 2025

Overall I think this is good.

I know this came up in the UX sync but I would strongly prefer to a permanent border on each node. It can be hard to tell the difference between different levels of shading for some colors:

Screen.Recording.2025-03-21.at.4.16.16.PM.mov

Also, not sure if this issue was there before but some of the text doesn't pass our own fg/bg ratio requirements.

https://googlechrome.github.io/lighthouse/viewer/?gist=8c2c4789c3cfe2ad99f43ecbbe39663c

@connorjclark
Copy link
Collaborator Author

connorjclark commented Mar 25, 2025

Yeah I could see us adding the border back. Let's stick to the design for now but will get a round of feedback when closer to done.

@connorjclark connorjclark merged commit 7422df6 into main Mar 28, 2025
27 checks passed
@connorjclark connorjclark deleted the treemap-colors-mult branch March 28, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@connorjclark @adamraine