Skip to content

misc: upgrade typescript target to es2023 #16316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 3 commits into from
Sep 29, 2025
Merged

misc: upgrade typescript target to es2023 #16316

connorjclark merged 3 commits into from
Sep 29, 2025

Conversation

@adamraine
Copy link
Contributor

@adamraine adamraine commented Jan 29, 2025 •
edited by connorjclark
Loading

Gives access to findLast which is compatible with Node 18.

closes #16423

@adamraine adamraine requested a review from a team as a code owner January 29, 2025 21:12
@adamraine adamraine requested review from connorjclark and removed request for a team January 29, 2025 21:12
@connorjclark
Copy link
Collaborator

connorjclark commented Jan 30, 2025 •
edited
Loading

yarn build-all output:

[1] ▲ [WARNING] Unrecognized target environment "es2023" [tsconfig.json]
    tsconfig-base.json:14:14:
      14 │     "target": "es2023",
         ╵               ~~~~~~~~

@adamraine
Copy link
Contributor Author

adamraine commented Jan 30, 2025

Chillin till we drop Node 18 support

@adamraine adamraine mentioned this pull request Apr 3, 2025
Closed
@adamraine
Copy link
Contributor Author

adamraine commented Apr 3, 2025

Closing for #16423

@adamraine adamraine closed this Apr 3, 2025
@connorjclark connorjclark reopened this Sep 29, 2025
@connorjclark connorjclark changed the title misc: upgrade TS target to es2023 misc: upgrade typescript target to es2023 Sep 29, 2025
connorjclark
connorjclark reviewed Sep 29, 2025
View reviewed changes
@connorjclark connorjclark merged commit 6300d99 into main Sep 29, 2025
32 of 33 checks passed
@connorjclark connorjclark deleted the ts-es-2023 branch September 29, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark left review comments

Assignees

No one assigned

Labels

chillin ❄

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade TS to es2023

2 participants

@adamraine @connorjclark