core: allow placeholder anchor elements #16287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution! This is a pretty specific exception IMO even if the use case is well defined. I looked into creating a general-case solution in #16292. I can't gurantee the solution will land given some of its complexity, so if we can't justify that solution then we can circle back to creating exception cases like this. |
Author
|
@adamraine Sorry for the late reply. Thank you! |
Collaborator
|
gonna look into landing #16292 thanks for taking a crack at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Acknowledgements: This is a continuation of Mr. @romainmenke 's great pull request. [#15894]
Since #15894 says there are many issues to be resolved, I would like to allow at least the a element that clearly indicates that it is a placeholder.
Related Issues/PRs
Base : #15894
Fixes : #15820