report: fix hidden audit handling for non-perf categories #15968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Apr 19, 2024
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
Thanks for splitting out, this is much more understandable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact refresh in #15962 revealed that we were not always handling the
hiddengroup correctly. Before, if an audit had grouphiddenit would only be omitted from the report if it would be in thefailedclump. So an audit marked N/A that had grouphiddenwould appear in the report (under the N/A section)This wasn't picked up by unit tests because the unit tests were indifferent to the
hiddengroup and the sample artifacts didn't have any audits with grouphiddenthat failed. With the artifact refresh, there was an audit that failed but was in grouphiddenwhich started tripping up the tests with incorrect expectations.This PR splits out the report fix and the associated test expectation corrections from #15962