Skip to content

core(service-worker): remove service-worker gatherer #15942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrianaixba merged 2 commits into from
Apr 12, 2024
Merged

core(service-worker): remove service-worker gatherer #15942

adrianaixba merged 2 commits into from
Apr 12, 2024

Conversation

@adrianaixba
Copy link
Collaborator

@adrianaixba adrianaixba commented Apr 11, 2024

continuation of the PWA category + unused gatherers removal: #15535

@adrianaixba adrianaixba requested a review from adamraine April 11, 2024 22:55
@adrianaixba adrianaixba marked this pull request as ready for review April 11, 2024 22:55
@adrianaixba adrianaixba requested a review from a team as a code owner April 11, 2024 22:55
adamraine
adamraine reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other references I found:

lighthouse/core/test/scripts/run-mocha-tests.js

Line 73 in 79c78be

'core/test/gather/gatherers/service-worker-test.js',

lighthouse/core/test/runner-test.js

Lines 38 to 41 in 79c78be

await td.replaceEsm('../gather/driver/service-workers.js', {
getServiceWorkerVersions: jestMock.fn().mockResolvedValue({versions: []}),
getServiceWorkerRegistrations: jestMock.fn().mockResolvedValue({registrations: []}),
});

lighthouse/types/artifacts.d.ts

Lines 144 to 145 in 79c78be

/** Version information for all ServiceWorkers active after the first page load. */
ServiceWorker: {versions: Crdp.ServiceWorker.ServiceWorkerVersion[], registrations: Crdp.ServiceWorker.ServiceWorkerRegistration[]};

@adrianaixba adrianaixba merged commit 9a62cd8 into main Apr 12, 2024
@adrianaixba adrianaixba deleted the rm-sw branch April 12, 2024 22:52
@alcance alcance mentioned this pull request Jul 10, 2024
Open
@jackkershaw jackkershaw mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

land-when-ci-is-green waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianaixba @adamraine @devtools-bot