core: remove no-unload-listeners audit
#15874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this clean up or fixing something pressing? I know long term the audit doesn't fit into a trace-first world, but removing (default) support for unload listeners on most sites doesn't start until Q3, with full removal by Q1 2025, so warning devs to not use unload listeners still seems like a good goal until sometime in that time. Could this live as-is for another few quarters and not hurt anything? |
Contributor
Author
We already warn about this in deprecations AND bfcache. IMO it doesn't need it's own audit anymore. |
Contributor
|
Ah, didn't realize (or just forgot) it was in deprecations. Nice! |
connorjclark
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15766
Also removes
GlobalListenersartifact.