misc(lint): enable no-conditional-assignment rule #14757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Feb 6, 2023
adamraine
reviewed
Feb 7, 2023
| let index = 0; | ||
| let prevNode; | ||
| while (prevNode = node.previousSibling) { | ||
| while (prevNode = node.previousSibling) { // eslint-disable-line no-cond-assign |
Contributor
There was a problem hiding this comment.
If we're going to enable this rule, we should try and stick to it.
There are other ways of organizing this code.
Contributor
|
😑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eslint.org/docs/latest/rules/no-cond-assign
I lost 30 minutes of debugging to this situation a few months back. (
=instead of===in a conditional.)it now haunts me.
it's part of eslint:recommended, but
eslint-config-googleflips it back off: https://github.com/google/eslint-config-google/blob/master/index.js#L37also.. the google config was archived last month! huh. bummer.