report: use narrow formatting for opportunity units #14723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Jan 27, 2023
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
s SGTM
I'd prefer to keep the additional space. I confirmed that 7.5ch is enough to render xx.xx in Tamil without wrapping.
adamraine
approved these changes
Jan 27, 2023
Member
|
There should be a space between time numeric value and unit. |
Contributor
Author
The space/no-space comes from Space is my preference too, but I would also prefer treating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14337
Everyone (including at least a few standards bodies) seem to agree the narrow
sis way better than the shortsec. We seemed in agreement thatsecis weird as well, so making the switch.That also allows us to narrow the text area again. It doesn't really make much sense to be specifying in terms of font-size, so I switched us over to using
7ch, which for Roboto is roughly equivalent to the 4x we were using before #14619.chisn't perfect if it's not a monospaced type, but it's a much more logical relative unit for a width.We could maybe go narrower, but unfortunately some locales still use a space before the unit and a period after for narrow formatting, so this lets us get
xx.xxsfor most locales andx.xx s.everywhere without wrapping (Tamil appears to result in the longest opportunity time strings).We could bump it up to 7.5ch? Or just live with the
.wrapping to the next line in that case until opportunity rendering is refactored (notably just sample_v2's first3.30wraps in Tamil on main with the currentcalc(5 * var(--report-font-size))since it's rendered as3.30 விநாடி).Before:
After:
Tamil:
