-
Notifications
You must be signed in to change notification settings - Fork 9.6k
core: enable async stacks in the DevtoolsLog gatherer #14717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has become a bit of a rabbit hole. While I do think it would be good to land this in the long term, it opens the door for some more complex challenges relating to scripts gathering and third parties. Incoming brain dump... Calling This PR moves that invocation into the With the introduction of the new 3P system, we will throw an error if we encounter a url that doesn't exist in the network records. Now we are collecting scripts that weren't fetched during the timespan, which can cause this error to be thrown if we attempt to use a url from one of the pre-timespan scripts in say the lighthouse/core/audits/valid-source-maps.js Lines 56 to 62 in 6de2ed2
In the future, I imagine we will classify the urls in |
As of #15009 this is no longer the case. @adamraine still want to do this PR? |
|
It has some organizational benefits, but I don't see myself spending any time on it in the near future |
Alternative to #14716
From what I can tell, we only access the initiator information when looking at network records constructed from the DevtoolsLog. I think it makes sense to encapsulate this with the DevtoolsLog.