Skip to content

Conversation

@connorjclark
Copy link
Collaborator

  • upgrade to latest babel and core-js
  • add debug: true to .babelrc to get some useful output from @babel/preset-env
  • remove es7.array.includes as a signal because recently a bug was noticed in FF

@connorjclark connorjclark requested a review from a team as a code owner January 25, 2023 21:59
@connorjclark connorjclark requested review from adamraine and removed request for a team January 25, 2023 21:59
@connorjclark connorjclark changed the title upgrade babel, remove array include signal core(legacy-javascript): upgrade babel and core-js, remove array include signal Jan 25, 2023

const moduleOptions = [
{esmodules: false},
{esmodules: false, bugfixes: false},
Copy link
Collaborator Author

@connorjclark connorjclark Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel 8 will change the defaults here eventually, so this is just preemptive.

@connorjclark connorjclark changed the title core(legacy-javascript): upgrade babel and core-js, remove array include signal core(legacy-javascript): upgrade babel and core-js Jan 25, 2023
@connorjclark connorjclark merged commit a02c013 into main Jan 26, 2023
@connorjclark connorjclark deleted the upgrade-leg-js-2023 branch January 26, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants