misc: split lhr compat code to lib/lighthouse-compatibility.js #14701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jan 23, 2023
core/util.cjs
Outdated
| * TODO(team): we all agree the LHR shape change is technical debt we should fix | ||
| * @param {LH.Result} result | ||
| * @return {LH.ReportResult} | ||
| * Upgrades an lhr object in-place to account for changes in the data structure over major versions. |
Contributor
There was a problem hiding this comment.
Maybe add a note here mentioning that this doesn't verify lhr shape
Collaborator
Author
There was a problem hiding this comment.
Wait, what about the name/interface makes that not clear already?
Contributor
There was a problem hiding this comment.
Fair, it's probably fine.
alexnj
reviewed
Jan 23, 2023
adamraine
approved these changes
Jan 23, 2023
connorjclark
force-pushed
the
compat-refactor
branch
from
e69b9bf to
439025a
Compare
connorjclark
force-pushed
the
compat-refactor
branch
from
439025a to
fbe6678
Compare
connorjclark
force-pushed
the
compat-refactor
branch
from
fbe6678 to
01a74a7
Compare
Collaborator
Author
|
Updated to account for recent util/report util split. |
1 task
connorjclark
force-pushed
the
compat-refactor
branch
from
01a74a7 to
a3eab18
Compare
connorjclark
force-pushed
the
compat-refactor
branch
from
a3eab18 to
915e671
Compare
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the changes made for convenience from those made to maintain backwards compatibility. Also exposes to node api.