core(emulation): retire moto g4, use moto g power #14674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
Contributor
|
We're also going to need to update DT settings when this is rolled since DT sets up emulation on it's own |
paulirish
reviewed
Jan 13, 2023
adamraine
reviewed
Jan 17, 2023
Contributor
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
Should we update the user agent as well?
connorjclark
force-pushed
the
moto-g-power
branch
from
c20b85b to
e71fb91
Compare
adamraine
reviewed
Feb 1, 2023
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Feb 2, 2023
Lighthouse plans to use the Moto G Power as the default emulated device for version 10.0. This will require the Moto G Power to be in the emulated device list when running Lighthouse in DevTools. Lighthouse PR: GoogleChrome/lighthouse#14674 Bug: None Change-Id: I2335bf8bc933b84fe13f85ea585ffb7e5c7ee506 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4214256 Commit-Queue: Adam Raine <[email protected]> Reviewed-by: Connor Clark <[email protected]> Reviewed-by: Mathias Bynens <[email protected]>
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Feb 3, 2023
This should accompany the release of Lighthouse 10.0 which switches the default mobile device to the Moto G power. Lighthouse PR: GoogleChrome/lighthouse#14674 Bug: None Change-Id: I84154e10181d9c02e32daa70893b7ff4ce5905aa Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4219345 Reviewed-by: Connor Clark <[email protected]> Commit-Queue: Connor Clark <[email protected]>
adamraine
reviewed
Feb 3, 2023
| url: 'http://localhost:10200/dobetterweb/lighthouse-1024x680.jpg?iar1', | ||
| }, | ||
| length: 1, | ||
| length: 2, |
Contributor
There was a problem hiding this comment.
What's the new one, should we add an expectation for it now?
Collaborator
Author
There was a problem hiding this comment.
it's unrelated, just so happened that the other audit being tested here got caught up. Don't wanna add it here...cuz it is named specific to its audit... :/
| "throttlingMethod": "simulate", | ||
| "screenEmulation": { | ||
| "mobile": true, | ||
| "width": 360, |
Contributor
There was a problem hiding this comment.
This is probably good for this PR, but we should do another complete artifact refresh to capture any changes the screen adjustment had.
| expect(oppElements.map(e => e.id).sort()).toEqual(oppAudits.map(a => a.id).sort()); | ||
| expect(oppElements.length).toBeGreaterThan(0); | ||
| expect(oppElements.length).toMatchInlineSnapshot('7'); | ||
| expect(oppElements.length).toMatchInlineSnapshot('6'); |
Contributor
There was a problem hiding this comment.
What was the change here?
Collaborator
Author
There was a problem hiding this comment.
I'm sure it was just image aspect ratio or responsive images no longer failing according to the artifacts.
adamraine
approved these changes
Feb 4, 2023
adamraine
suggested changes
Feb 4, 2023
adamraine
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #14256