core(full-page-screenshot): remove audit, move to top-level #14657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
connorjclark
commented
Jan 10, 2023
adamraine
reviewed
Jan 10, 2023
| type: 'string', | ||
| describe: 'The path to the budget.json file for LightWallet.', | ||
| }, | ||
| 'disable-full-page-screenshot': { |
Contributor
There was a problem hiding this comment.
This is a bit long, I think we can shorten to --disable-screenshot
Collaborator
Author
There was a problem hiding this comment.
There are so many screenshots that could refer to.
adamraine
reviewed
Jan 10, 2023
adamraine
approved these changes
Jan 12, 2023
| */ | ||
| initFeatures(lhr) { | ||
| this.json = lhr; | ||
| this._fullPageScreenshot = Util.getFullPageScreenshot(lhr); |
Contributor
There was a problem hiding this comment.
Why do we need to store this on the object? getFullPageScreenshot isn't an expensive operation.
Collaborator
Author
There was a problem hiding this comment.
Typechecking. It needed to be set to a variable somewhere to do type narrowing.
Co-authored-by: Adam Raine <[email protected]>
connorjclark
changed the title
connorjclark
changed the title
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full-page-screenshotauditMake FullPageScreenshot a legacy base artifact. Remains a regular FR artifact.this was a bad idea because in legacy bf-cache-failures (which is disabled for FR) needs to happen LAST, so this became too hacky to run FPS code at just the right time in legacy afterPass.lhr.fullPageScreenshotdisableFullPageScreenshotsetting and--disable-full-page-screenshotCLI flag