Skip to content

core: use config to name every config json #14649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamraine merged 1 commit into from
Jan 13, 2023
Merged

core: use config to name every config json #14649

adamraine merged 1 commit into from
Jan 13, 2023

Conversation

@adamraine
Copy link
Contributor

@adamraine adamraine commented Jan 4, 2023 •
edited
Loading

#14547 (comment)

Type renames to be done in a follow-up.

@adamraine adamraine requested a review from a team as a code owner January 4, 2023 19:56
@adamraine adamraine requested review from brendankenny and removed request for a team January 4, 2023 19:56
connorjclark
connorjclark approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems sensible here.

@adamraine adamraine merged commit c35c28e into main Jan 13, 2023
@adamraine adamraine deleted the rename-configjson branch January 13, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@brendankenny brendankenny

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamraine @connorjclark @brendankenny @devtools-bot