docs: update user-flow.md to reflect current release #14604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change flow import path from `import lighthouse from 'lighthouse/core/api.js';` to `import {startFlow} from 'lighthouse/lighthouse-core/fraggle-rock/api.js';`
- remove `startNavigation`/`endNavigation`
- change interactive navigation with `startNavigation`/`endNavigation` to a callback navigation
- change `beginTimepsan` to `startTimespan`
ChristopherPHolder
requested review from
adamraine
and removed request for
a team
adamraine
suggested changes
Dec 12, 2022
Contributor
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is what I was imagining on main.
- remove - revert timespan to navigation change
adamraine
reviewed
Dec 12, 2022
Contributor
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
Should we also remove the reference to (Lighthouse v10) in L3?
Yeah sounds good.
Co-authored-by: Adam Raine <[email protected]>
adamraine
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating the docs for User Flow to reflect the current release
Change flow import path from
import lighthouse from 'lighthouse/core/api.js';toimport {startFlow} from 'lighthouse/lighthouse-core/fraggle-rock/api.js';remove
startNavigation/endNavigationchange interactive navigation with
startNavigation/endNavigationto a callback navigationchange
beginTimepsantostartTimespanRelated Issues/PRs
Closes #14603