Skip to content

Conversation

@MrBrain295
Copy link
Contributor

Summary

Remove trace-of-tab references.

Related Issues/PRs

This fixes: #14514

@MrBrain295 MrBrain295 requested a review from a team as a code owner December 6, 2022 03:13
@MrBrain295 MrBrain295 requested review from adamraine and removed request for a team December 6, 2022 03:13
@google-cla
Copy link

google-cla bot commented Dec 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentions a couple references in comments if you search for "trace of tab"

@adamraine adamraine changed the title Remove trace-of-tab references core: remove trace-of-tab references Dec 6, 2022
@vercel
Copy link

vercel bot commented Dec 7, 2022

@MrBrain295 is attempting to deploy a commit to the GoogleChrome Team on Vercel.

A member of the Team first needs to authorize it.

@MrBrain295 MrBrain295 requested a review from adamraine December 7, 2022 22:30
Copy link
Contributor

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also change "trace of tab" in these comments to "the processed trace":

// Include all timestamps of interest from trace of tab

// Includes timestamps from trace of tab

Copy link
Contributor

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@adamraine adamraine merged commit 03674e9 into GoogleChrome:main Dec 9, 2022
@MrBrain295 MrBrain295 deleted the patch-1 branch December 9, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove old references to trace of tab

4 participants