Skip to content

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 5, 2022

github:silent broke seemingly..

edit: and it appears that after adopting the new stuff, it's still broken.......


well.. the PR is just barely useful then. moving us off some deprecated things.

Also: as a future note.. the configuration is shared between here and https://vercel.com/googlechrome/lighthouse/settings/general

@paulirish paulirish requested a review from a team as a code owner December 5, 2022 23:42
@paulirish paulirish requested review from brendankenny and removed request for a team December 5, 2022 23:42
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lighthouse ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:47PM (UTC)

@adamraine
Copy link
Contributor

Why the vercel comment in this PR? Did it not work or did the comment happen one time while configuring?

@connorjclark
Copy link
Collaborator

maybe only main branch counts

@paulirish
Copy link
Member Author

Why the vercel comment in this PR? Did it not work or did the comment happen one time while configuring?

I discovered a regression ;) vercel/vercel#9014

@paulirish paulirish merged commit 5cbe4f8 into main Dec 6, 2022
@paulirish paulirish deleted the now-to-vercel branch December 6, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants