Skip to content

core(lantern): add comment about node times being in microseconds #14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devtools-bot merged 1 commit into from
Nov 29, 2022
Merged

core(lantern): add comment about node times being in microseconds #14568

devtools-bot merged 1 commit into from
Nov 29, 2022

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Nov 29, 2022

we got confused here #14567 (comment)

lantern cpu nodes just use the trace event's ts value, which is microseconds. network node is multiplied to match

@connorjclark connorjclark requested a review from a team as a code owner November 29, 2022 23:15
@connorjclark connorjclark requested review from adamraine and removed request for a team November 29, 2022 23:15
@paulirish
Copy link
Member

paulirish commented Nov 29, 2022

also

https://github.com/GoogleChrome/lighthouse/blob/main/core/lib/tracehouse/main-thread-tasks.js is mostly microsec (except for a few ones)
https://github.com/GoogleChrome/lighthouse/blob/main/core/computed/critical-request-chains.js is microsec
https://github.com/GoogleChrome/lighthouse/blob/main/core/audits/critical-request-chains.js is both microsec and ms depending on where you are

@devtools-bot devtools-bot merged commit e1b4ca2 into main Nov 29, 2022
@devtools-bot devtools-bot deleted the lantern-comment-micros branch November 29, 2022 23:28
@connorjclark connorjclark changed the title core(lantern): add comment to about node times being in microseconds core(lantern): add comment about node times being in microseconds Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@connorjclark @paulirish @adamraine @devtools-bot