deps: upgrade third-party-web to 0.20.2 #14546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is the delta in sample json expected? May need to tweak the sample artifacts to restore some failing audit result there. |
Member
Author
|
No, the delta exists due to the entity not being recognized. It should be recognized, hence #14548. |
Member
Author
|
Alternatively, if we choose to not recognize the ~1040 entities that are missing due to not being present in HTTPArchive-data set, I'll go ahead update the sample json. |
Collaborator
|
let's land #14548 first, and hopefully get the sample json to not lose data |
connorjclark
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.