core: expose default and desktop configs on index.js
#14543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Having the desktop config in an accessible place is better than telling people to pull it in from I can't think of a specific use case for having the default config exposed here, but there isn't a reason to not include it either. |
brendankenny
approved these changes
Nov 17, 2022
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
Makes sense. We should finally make extends work with the other presets (desktop/perf/experimental, etc) and maybe even arbitrary extends config chains, but sounds good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be useful to have these two at the top level api.
Ref #14048