core: add BFCacheFailures artifact
#14485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Should we track the |
Collaborator
so like: naming up to adam tho |
adamraine
changed the title
BFCacheErrors artifactBFCache artifact
adamraine
changed the title
BFCache artifactBFCacheFailures artifact
adamraine
commented
Nov 10, 2022
| const events = []; | ||
| for (const event of context.dependencies.DevtoolsLog) { | ||
| if (event.method === 'Page.backForwardCacheNotUsed') { | ||
| events.push(event.params); |
Collaborator
There was a problem hiding this comment.
will we need the urls associated with this?
Contributor
Author
There was a problem hiding this comment.
Potentially in the future if we start surfacing more than one failure. In that scenario, it would be easy to add a url parameter to Artifacts.BFCacheFailure. I don't think we should worry about it right now though.
connorjclark
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off the artifact part from #14465 + added some test cases