Skip to content

Conversation

@brendankenny
Copy link
Contributor

backport of just what's needed to include rendererStartTime from #14311 in the network-requests hidden audit for richer timing information in the November HTTP Archive run.

No other changes (or uses of rendererStartTime) included.

Comment on lines +86 to +87
/** When the renderer process initially discovers a network request. */
this.rendererStartTime = -1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still in seconds because everything else is without the rest of #14311

isLinkPreload: networkRecord.isLinkPreload,
},
timestamp: networkRecord.redirectResponseTimestamp || networkRecord.startTime || 0,
timestamp: networkRecord.redirectResponseTimestamp || networkRecord.rendererStartTime ||
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test in this PR explicitly sets rendererStartTime, but by default network-records-to-devtools-log checks that round-tripping networkRecords->DevtoolsLog->networkRecords reproduces the input and some tests (like uses-http2) use slightly altered but real network records that have an actual rendererStartTime that now needs to make its way to the output

@brendankenny
Copy link
Contributor Author

not sure what's up with the screenshot smoke failures, but seems like the same ones happened in 9.6.7: for example

@adamraine
Copy link
Contributor

not sure what's up with the screenshot smoke failures, but seems like the same ones happened in

Yeah we update smokehouse to be more flexible with screenshot elements somewhere along the way. We can safely ignore those.

@brendankenny brendankenny merged commit 364ccdf into branch-9 Oct 31, 2022
@brendankenny brendankenny deleted the branch-9-renderer-start-time branch October 31, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants