Skip to content

Conversation

@adamraine
Copy link
Contributor

Part of #14354

@adamraine adamraine added the 10.0 label Oct 18, 2022
@adamraine adamraine requested a review from a team as a code owner October 18, 2022 22:10
@adamraine adamraine requested review from brendankenny and removed request for a team October 18, 2022 22:10
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can confirm an axe check won't mix incomplete and failure by looking at the constitute checks source (here's a check source) and just seeing if any can return false And undefined (replace false with true if the check shows up in the rules "none"...)

I did the above for th-has-data-cells and it checks out. LGTM.

I did the above for bypass and found it should only return true or false, so wondered why it was giving incompletes (that should be only for undefined). Turns out rules have a "reviewOnFail" property. LGTM.

video-caption LGTM

@adamraine adamraine merged commit 51b9eb1 into main Oct 19, 2022
@adamraine adamraine deleted the some-axe-informative branch October 19, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants