Skip to content

tests: assert to assert/strict #14412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 3 commits into from
Oct 7, 2022
Merged

tests: assert to assert/strict #14412

connorjclark merged 3 commits into from
Oct 7, 2022

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Sep 30, 2022

First commit is mechanical, no behavioral changes at all.

Second commit changes a few assert to assert/strict, that's the one to look at closely.

Closes #13883

@connorjclark connorjclark requested a review from a team as a code owner September 30, 2022 16:55
@connorjclark connorjclark requested review from adamraine and removed request for a team September 30, 2022 16:55
@connorjclark
Copy link
Collaborator Author

connorjclark commented Sep 30, 2022 •
edited
Loading

Cannot find package 'assert' imported from /Users/cjamcl/src/lighthouse/build/plugins/inline-fs.js

Ah, Node 14 doesn't support assert/strict :(

But in Oct. (2022-10-18) we "can" drop Node 14... #14345

@connorjclark connorjclark merged commit b61e8c3 into main Oct 7, 2022
@connorjclark connorjclark deleted the assert-strict branch October 7, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use 'assert/strict'

3 participants

@connorjclark @adamraine @devtools-bot