core: remove trace-of-tab #14237
Merged
core: remove trace-of-tab #14237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
that's just for devtools. we still have cli |
connorjclark
approved these changes
Jul 25, 2022
Contributor
Author
The smoke test is disabled though, and there are CJS/ESM issues when I try to reenable it on the CLI runner. Running Merging this shouldn't change anything, but maybe we should fix the ESM issue before assuming anything. |
Collaborator
|
Well, they don't use the gatherer at all now, right? So this PR seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13962
@connorjclark do we have any pubads tests enabled right now, or are they still waiting on https://github.com/GoogleChrome/lighthouse/blob/master/clients/devtools/devtools-entry.js#L55