tests(devtools): use linux for CI #14199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This would be nice but the NO_FCP stuff is way too common. Will need to investigate this before considering a merge. |
connorjclark
requested review from
connorjclark
and removed request for
brendankenny
adamraine
commented
Jul 11, 2022
Contributor
Author
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
There are a lot of changes to the pptr-run-devtools.js that should make the script more robust. I'm happy to split those out into a separate PR because it would benefit us on macos as well.
I tried to highlight the important changes in comments.
connorjclark
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves us ~13mins on the build step
Before: https://github.com/GoogleChrome/lighthouse/actions/runs/2626494537
After: https://github.com/GoogleChrome/lighthouse/actions/runs/2666800793
Unfortunately, we're getting some flaky but very common NO_FCP errors in this branch.
We could also introduce a general
smoke-macosjob that runs CLI smokes just to cover all our bases.