Skip to content

Conversation

@connorjclark
Copy link
Collaborator

Unlike with webtests, e2e tests specify each test file in BUILD.gn for devtools build system. So we'll need to sync these files otherwise a mismatch in test files will result in build errors / tests not running.

@connorjclark connorjclark requested a review from a team as a code owner July 2, 2022 00:05
@connorjclark connorjclark requested review from brendankenny and removed request for a team July 2, 2022 00:05
@connorjclark connorjclark requested review from adamraine and removed request for brendankenny July 2, 2022 00:05
Copy link
Contributor

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connorjclark
Copy link
Collaborator Author

  1. I want to see that without a synced-test folder, CI works. currently master fails
  2. Let's do a few more tests before we start syncing, we're gonna have soon I bet.

@devtools-bot devtools-bot merged commit 03af403 into master Jul 2, 2022
@devtools-bot devtools-bot deleted the dt-tests-buildgn branch July 2, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants