core: move network recorder and monitor to EventEmitter #14152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Jun 23, 2022
| * @typedef {{ | ||
| * requeststarted: [NetworkRequest], | ||
| * requestfinished: [NetworkRequest], | ||
| * }} NetworkRecorderEventMap |
Contributor
There was a problem hiding this comment.
nit: can this be done with a proper multiline typdef?
Contributor
Author
There was a problem hiding this comment.
It could be, but the main benefit of the @property form is you can document the properties. This won't ever be used as the type for a real object, the properties are for type lookup by event name, so there wouldn't ever be anywhere those jsdoc strings would show up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14078
Like with
sessionin #14147, movesNetworkRecorderandNetworkMonitorfrom having event emitters to being event emitters.Normally composition is 🥇, but in this case it was just requiring us to declare delegation methods to have equivalent functionality. Technically inheritance now, but functionality is disjoint, so let's just call it a mixin still :)
No functionality or test changes.