Skip to content

core(devtoolslog): include Target and Runtime domains #14101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devtools-bot merged 2 commits into from
Jun 8, 2022
Merged

core(devtoolslog): include Target and Runtime domains #14101

devtools-bot merged 2 commits into from
Jun 8, 2022

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Jun 8, 2022

This isn't necessary for our runtime, but is very useful for debugging. And the overhead is very small.

Here's the JSON size per domain of all the domains (for a run on the oopif-requests page):

Page:      11,529
Network:  660,047
Runtime:      588
Target:       980
Debugger:  14,559
Audits:     2,433
Tracing:  828,424

@paulirish paulirish requested a review from a team as a code owner June 8, 2022 02:18
@paulirish paulirish requested review from adamraine and removed request for a team June 8, 2022 02:18
@adamraine
Copy link
Contributor

adamraine commented Jun 8, 2022

Here's the JSON size per domain of all the domains (for a run on the oopif-requests page):

What's the breakdown of a heavy page like https://www.cnn.com/?

@paulirish
Copy link
Member Author

paulirish commented Jun 8, 2022

Here's the JSON size per domain of all the domains (for a run on the oopif-requests page):

What's the breakdown of a heavy page like cnn.com?

this is lighthouse https://www.cnn.com/ -G --preset=desktop --legacy-navigation

image

@devtools-bot devtools-bot merged commit dd16cd0 into master Jun 8, 2022
@devtools-bot devtools-bot deleted the dtlogmoredomaisn branch June 8, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulirish @adamraine @devtools-bot @connorjclark